Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

String aliases are preserved #3820

Merged
merged 1 commit into from
Oct 6, 2018
Merged

String aliases are preserved #3820

merged 1 commit into from
Oct 6, 2018

Conversation

lnhsingh
Copy link
Contributor

@lnhsingh lnhsingh commented Oct 3, 2018

CockroachDB now distinguishes CHAR and VARCHAR, as mandated by the SQL standard and PostgreSQL compatibility.

Closes #3693.

@lnhsingh lnhsingh requested a review from knz October 3, 2018 21:20
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@cockroach-teamcity
Copy link
Member

http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/81e7729e66da7023098aa703bf3d8875e93c0eac/

@rmloveland rmloveland mentioned this pull request Oct 4, 2018
Closed
rmloveland
rmloveland approved these changes Oct 4, 2018
View reviewed changes
Copy link
Contributor

@rmloveland rmloveland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lnhsingh lnhsingh merged commit 506ec1f into master Oct 6, 2018
@lnhsingh lnhsingh deleted the string-aliases branch October 6, 2018 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knz knz knz approved these changes

@rmloveland rmloveland rmloveland approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lnhsingh @cockroach-teamcity @knz @rmloveland