-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Learn CRDB SQL MovR update #5216
Learn CRDB SQL MovR update #5216
Conversation
d07390a
to
03b5f55
Compare
03b5f55
to
2dfb9d0
Compare
Added managed version of Learn CRDB SQL
2dfb9d0
to
41a0afb
Compare
@jseldess As you can see in the file diff, I crammed in two separate Learn CRDB SQL instructions... One that uses MovR, for the standard 19.2 docs, and one that does not use MovR (it is essentially identical to the 19.1 Learn CRDB SQL page), for managed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's an argument to be made that, since no content on the page is really shared anymore, it might be fine to split this into 2 files, e.g., learn-cockroachdb-sql.md
and managed-learn-cockroachdb.sql.md
. But let's leave it as a single file for now.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @ericharmeling and @jseldess)
v19.2/learn-cockroachdb-sql.md, line 20 at r1 (raw file):
Do one of the following: {% include {{page.version.version}}/sql/movr-start.md %}
I have a few ideas about improving this include, but I'll show you in a separate PR.
#5040
This PR includes the "Learn CockroachDB SQL" MovR update, originally a part of the #5075 PR. I broke it out into a different feature branch because of the conflicts with MSO...