safe details/messages: clarify cases with empty formats #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- when format is empty but there are additional arguments, still perform the formatting (the values will be included) - when format is empty and there are no additional argument, make the safe detail wrapper present itself as "empty" during `%+v` formatting
knz
force-pushed
the
master
branch
2 times, most recently
from
2765173
to
0b2a923
Compare
RaduBerinde
approved these changes
Jul 9, 2019
There was a problem hiding this comment.
Reviewed 3 of 4 files at r1, 2 of 3 files at r2, 3 of 3 files at r3.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @knz)
errutil_api.go, line 113 at r2 (raw file):
} // HandleAsAssertionFailureDepth
[nit] forwards a definition.
... this can be used instead of `NewAssertionErrorWithWrappedErr(err, "")` to avoid the surprising/unclear empty string argument.
Before: ``` some error - original cause behind barrier: original message - original details ``` After: ``` some error - original cause behind barrier: original message - original details ``` Suggested by @RaduBerinde.
knz
commented
Jul 9, 2019
There was a problem hiding this comment.
Reviewable status:
complete! all files reviewed, all discussions resolved
errutil_api.go, line 113 at r2 (raw file):
Previously, RaduBerinde wrote…
[nit] forwards a definition.
Done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
perform the formatting (the values will be included)
make the safe detail wrapper present itself as "empty"
during
%+vformattingHandleAsAssertionFailure()to avoidNewAssertionErrorWithWrappedErrf(err, "")and a surprising empty string.This change is