Allow smaller ranges in Jepsen tests #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jepsen attempts to set custom range sizes using values not allowed under the new validation added in [1]. We disable that validation by setting the COCKROACH_MIN_RANGE_MAX_BYTES environment variable when startting cockroachdb. [1] cockroachdb/cockroach#96725
renatolabs
added a commit
to renatolabs/cockroach
that referenced
this pull request
Mar 27, 2023
This commit bumps the jepsen version now to include a fix that allows jepsen to set custom range sizes. See: cockroachdb/jepsen#34 Epic: none Release note: None
renatolabs
added a commit
to renatolabs/cockroach
that referenced
this pull request
Mar 27, 2023
This commit bumps the jepsen version now to include a fix that allows jepsen to set custom range sizes. See: cockroachdb/jepsen#34 Epic: none Release note: None
herkolategan
approved these changes
Mar 28, 2023
There was a problem hiding this comment.
Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @shralex, @smg260, and @srosenberg)
|
This change is |
herkolategan
approved these changes
Mar 28, 2023
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @shralex, @smg260, and @srosenberg)
|
TFTR! |
renatolabs
added a commit
to renatolabs/cockroach
that referenced
this pull request
Mar 28, 2023
This commit bumps the jepsen version now to include a fix that allows jepsen to set custom range sizes. See: cockroachdb/jepsen#34 Epic: none Release note: None
renatolabs
added a commit
to renatolabs/cockroach
that referenced
this pull request
Mar 29, 2023
This commit bumps the jepsen version now to include a fix that allows jepsen to set custom range sizes. See: cockroachdb/jepsen#34 Epic: none Release note: None
craig bot
pushed a commit
to cockroachdb/cockroach
that referenced
this pull request
Mar 30, 2023
99669: roachtest: bump jepsen version r=smg260 a=renatolabs This commit bumps the jepsen version now to include a fix that allows jepsen to set custom range sizes. See: cockroachdb/jepsen#34 Epic: none Release note: None 99716: kvserver: use qps for hot ranges sorting r=koorosh a=kvoli We introduced CPU balancing by default in #97424. This had the side effect of changing the hot ranges api to return the hottest replicas by CPU, rather than QPS. This patch updates the replica rankings struct to support tracking both by CPU and QPS simultaneously. The hot ranges API collects the top k by QPS and the store rebalancer collects depending on the setting of `kv.allocator.load_based_rebalancing.objective`, which is by default `cpu`. Resolves: #99605 Co-authored-by: Renato Costa <renato@cockroachlabs.com> Co-authored-by: Austen McClernon <austen@cockroachlabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jepsen attempts to set custom range sizes using values not allowed under the new validation added in [1]. We disable that validation by setting the COCKROACH_MIN_RANGE_MAX_BYTES environment variable when startting cockroachdb.
[1] cockroachdb/cockroach#96725