Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

db: SetOptions doesn't always respect changed filters #1621

Closed
jbowens opened this issue Apr 5, 2022 · 0 comments · Fixed by #1631
Closed

db: SetOptions doesn't always respect changed filters #1621

jbowens opened this issue Apr 5, 2022 · 0 comments · Fixed by #1631
Labels
C-bug Something isn't working

Comments

@jbowens
Copy link
Collaborator

jbowens commented Apr 5, 2022

SetOptions needs to propagate changed block property filters and table filter to leaf iterators when reusing an existing iterator stack.
@jbowens jbowens added the C-bug Something isn't working label Apr 5, 2022
jbowens added a commit to jbowens/pebble that referenced this issue Apr 6, 2022
@jbowens
db: respect changed filters in SetOptions
0794f89 
Rebuild the iterator stack if filters (block or table) are modified.

Fix cockroachdb#1621.
@jbowens jbowens mentioned this issue Apr 6, 2022
Merged
jbowens added a commit to jbowens/pebble that referenced this issue Apr 6, 2022
@jbowens
db: respect changed filters in SetOptions
4ab231e 
Rebuild the iterator stack if filters (block or table) are modified.

Fix cockroachdb#1621.
jbowens added a commit to jbowens/pebble that referenced this issue Apr 6, 2022
@jbowens
db: respect changed filters in SetOptions
37a894d 
Rebuild the iterator stack if filters (block or table) are modified.

Fix cockroachdb#1621.
jbowens added a commit that referenced this issue Apr 6, 2022
@jbowens
db: respect changed filters in SetOptions
5cd6064 
Rebuild the iterator stack if filters (block or table) are modified.

Fix #1621.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

db: respect changed filters in SetOptions jbowens/pebble
1 participant
@jbowens