Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "sstable: skip two known test flakes on windows" #2240

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

nicktrav
Copy link
Contributor

This reverts commit 65ff304.

Touches #1897.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@nicktrav nicktrav marked this pull request as ready for review January 12, 2023 15:40
@nicktrav nicktrav requested review from jbowens, bananabrick and a team January 12, 2023 15:41
@nicktrav
Copy link
Contributor Author

I'm not 100% on the underlying issue being resolved, but let's see how we go ...

Copy link
Collaborator

@jbowens jbowens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@nicktrav
Copy link
Contributor Author

TFTR!

@nicktrav nicktrav merged commit dac60ce into cockroachdb:master Jan 12, 2023
@nicktrav nicktrav deleted the nickt.re-enable-windows-tests branch January 12, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants