Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

db: avoid keyspanimpl.TableNewSpanIter closure allocation #3584

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

db: avoid keyspanimpl.TableNewSpanIter closure allocation #3584

wants to merge 1 commit into from

Commits on May 3, 2024

  1. db: avoid keyspanimpl.TableNewSpanIter closure allocation 

    The tableNewIters func requires a context, but the keyspanimpl.TableNewSpanIter
func used by keyspan.LevelIter did not take one. This required iterator
construction to close over the context and the tableNewIters to create an
keyspanimpl.TableNewSpanIter, forcing an allocation.

This commit refactors the keyspanimpl.LevelIter to embed a context, like the
point iterator's levelIter, and propagate the context into TableNewSpanIter
through an argument.
    @jbowens
    jbowens committed May 3, 2024
    Configuration menu
    Copy the full SHA
    38e5fe4 View commit details
    Browse the repository at this point in the history