Update CC SDK to v1.4.0 #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No longer relevant since the API key can come from either the config or env variable.
sjbarag
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
Thanks for the review-method suggestion – it made things super easy to read.
Looks great @erademacher! Thanks for the clean commit structure 😃
|
|
||
| ### Notes | ||
|
|
||
| - The CockroachDB Cloud Terraform Provider is now generally available with semantic versioning compatibility promises. |
|
TFTR!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a group of four commits that are probably best reviewed separately:
After this is approved, I'm going to tag v1.0 🎉
Commit checklist
make generate)