private endpoint services: support all clouds #189
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carloruiz
force-pushed
the
private-endpoint-services
branch
from
4bcb03e
to
79b7505
Compare
|
acceptance test |
carloruiz
force-pushed
the
private-endpoint-services
branch
from
79b7505
to
2ab0778
Compare
|
There were some failures in the acceptance tests ran against prod with the tag v1.3.2, so the release was not done. This commit fixes the acceptance test failures and updates the CHANGELOG to include this PR's changes into the v1.3.2 release. Once this PR is merged, I will move the tag to the resulting SHA and restart the pre-release process. Jira ticket with bug info CC-27459 |
fantapop
reviewed
Mar 15, 2024
Previously, the private_endpoint_services resource only supported the creation of AWS private endpoint services. This commit removes this restriction, now all clouds are supported. Additionally this commit fixes a bug that caused the private_endpoint_service resource to be created without the resource state being loaded into the state file. Lastly, this commit bumps the CRDB version used for testing.
carloruiz
force-pushed
the
private-endpoint-services
branch
from
809b726
to
d668bbc
Compare
|
TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the private_endpoint_services resource only supported the creation of AWS private endpoint services. This commit removes this restriction, now all clouds are supported. Additionally this commit fixes a bug that caused the private_endpoint_service resource to be created without the resource state being loaded into the state file. Lastly, this commit bumps the CRDB version used for testing.
Commit checklist
make generate)