Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix inconsistent result error when using cockroach_version #58

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

erademacher
Copy link
Contributor

Transform version strings from API results into the format we expect for cluster creation.

Also moved the dedicated test cluster to GCP and us-central1 since it's a little bit cheaper and closer to our control plane.

Tranform version strings from API results into the format we expect
for cluster creation.
Copy link
Contributor

@jenngeorge jenngeorge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erademacher
Copy link
Contributor Author

TFTR!

@erademacher erademacher merged commit 187e097 into main Nov 10, 2022
@erademacher erademacher deleted the read_version branch November 10, 2022 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants