Update timeouts and clean up constants #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanluu12345
approved these changes
Nov 16, 2022
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @marksoper)
Cluster update operations can take a pretty long time, especially multiregion clusters. We had an SE bump into the timeout, even though it was still chugging along. Bumped it to 2 hours. Dropped the endpoint connection timeout to 10 minutes (usually completes in ~30s). Left cluster and endpoint service creation unchanged. Generally refactored timeout constants, and also a couple unrelated cluster state constants that were hard coded and at risk of going out of sync with the API. Also opportunistically fixed a fixed a segfault that happened if a call to GetCluster fails in the wait loop, trying to copy the value of a nil cluster pointer.
erademacher
force-pushed
the
bump_cluster_update_timeout
branch
from
c2b38e5
to
cb3b8a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cluster update operations can take a pretty long time, especially multiregion clusters. We had an SE bump into the timeout, even though it was still chugging along. Bumped it to 2 hours. Dropped the endpoint connection timeout to 10 minutes (usually completes in ~30s). Left cluster and endpoint service creation unchanged.
Generally refactored timeout constants, and also a couple unrelated cluster state constants that were hard coded and at risk of going out of sync with the API.
Also opportunistically fixed a fixed a segfault that happened if a call to GetCluster fails in the wait loop, trying to copy the value of a nil cluster pointer.
Add a description of the problem this PR addresses and an overview of how this PR works.