Add logexportconfig resource

[jenngeorge]

Add a new LogExportConfig resource, which manages
the log export configuration for a cluster.

---

This change is 

[erademacher]

This looks great! So just to make sure I understand, EnableLogExport is declarative, right? So Create and Update are basically the same operation?

Reviewed 3 of 5 files at r1.
Reviewable status: 3 of 5 files reviewed, 3 unresolved discussions (waiting on @jenngeorge)

---

internal/provider/log_export_config_resource.go line 81 at r1 (raw file):

				},
				"min_level": schema.StringAttribute{
					Required:            true,

This probably shouldn't actually be required if it's allowed to be empty, like in the example.

---

internal/provider/log_export_config_resource.go line 181 at r1 (raw file):

		resp.Diagnostics.AddError(
			"Error enabling LogExport",
			fmt.Sprintf("Could not enable LogExport: %v", formatAPIErrorMessage(err)),

nit: Mixing "LogExport" and "log export". Should probably standardize on "log export".

---

internal/provider/log_export_config_resource.go line 210 at r1 (raw file):

	minLevel := group.MinLevel.ValueString()
	clientGroup := client.LogExportGroup{
		Channels: &channels,

The fact that the client object here takes a bunch of pointers suggests that none of these fields are marked as required in the OpenAPI spec. Should they be? If so, we should probably make an API update before merging this change.

[jenngeorge]

Thanks @erademacher ! Reviewable is not letting me publish comments at the moment, so responding here:

This looks great! So just to make sure I understand, EnableLogExport is declarative, right? So Create and Update are basically the same operation?

Right! This doc mentions that https://www.cockroachlabs.com/docs/cockroachcloud/export-logs.html?filters=gcp-log-export#update-an-existing-log-export-configuration, but I'll also update the API reference from "Create a Log Export configuration for a cluster" to "Create or update the Log Export configuration for a cluster".

				},
				"min_level": schema.StringAttribute{
					Required:            true,

This probably shouldn't actually be required if it's allowed to be empty, like in the example.

Good catch! I'll ask about this while making the API update.

		resp.Diagnostics.AddError(
			"Error enabling LogExport",
			fmt.Sprintf("Could not enable LogExport: %v", formatAPIErrorMessage(err)),

nit: Mixing "LogExport" and "log export". Should probably standardize on "log export".

Good catch, fixed!

	minLevel := group.MinLevel.ValueString()
	clientGroup := client.LogExportGroup{
		Channels: &channels,

The fact that the client object here takes a bunch of pointers suggests that none of these fields are marked as required in the OpenAPI spec. Should they be? If so, we should probably make an API update before merging this change.

Yeah, it looks like they should probably be marked required. I'll check and make an API update!

[jenngeorge]

Here's a crl google doc with manual testing examples . It includes the AWS and GCP workflow examples, plus various create / update / delete attempts that build off the examples.

Reviewable status: 0 of 10 files reviewed, 3 unresolved discussions (waiting on @erademacher)

[erademacher]

Reviewed 3 of 7 files at r3, 3 of 6 files at r4, 4 of 4 files at r5, 1 of 1 files at r6, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @jenngeorge)

---

internal/provider/log_export_config_resource.go line 212 at r6 (raw file):

	var groups []LogExportGroup
	if len(spec.GetGroups()) != 0 {
		groups = make([]LogExportGroup, 0, len(spec.GetGroups()))

super nit: There probably aren't enough items in these slices for it to make a big difference, but if no items are getting filtered out, it's generally more efficient to set the length to the right size (instead of the capacity) and use the index instead of append.

[jenngeorge]

TFTR! Recent pushes include cloud provider compatibility checks that were present during manual testing but I had failed to push, rebasing, and indexing instead of appending.

Reviewable status: 4 of 10 files reviewed, 1 unresolved discussion (waiting on @erademacher)

---

internal/provider/log_export_config_resource.go line 212 at r6 (raw file):

Previously, erademacher (Evan Rademacher) wrote…

super nit: There probably aren't enough items in these slices for it to make a big difference, but if no items are getting filtered out, it's generally more efficient to set the length to the right size (instead of the capacity) and use the index instead of append.

Good catch, fixed!