-
Notifications
You must be signed in to change notification settings - Fork 31
Conversation
No need to merge to |
Will create a new branch with no PR, because it's very tempting to press "Delete branch" in this PR at any time in the future. |
we typically fast forward push master to the referenced commit after the cockroachdb/cockroach PR referencing it merges at which point it is permanently going to be reachable from a protected branch; at that point you can delete the named branch |
@dt What if Does it never happen? |
vendored/master is protected, so if someone made a new vendored commit off of an older parent than the current head, you'd need a merge commit to push it |
Makes sense, thanks @dt. Then my plan is to just merge this PR after cockroachdb/cockroach#88470 is merged. This will result in a fast-forwarded |
perfect -- in the meantime it looks like nobody has pushed the currently crdb referenced commit to master here for awhile (meaning it isn't protected) so I'll do that real quick. |
@dt thanks. I will rebase after you do it, this PR will nicely contain one commit then. |
1ceffd9
to
cdfaa94
Compare
No description provided.