fix: change value 'response' by value 'result' of event name when socket client is registered #347
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have been working with the Dalai API to connect it with a simple client to run on node.js, following the example redacted in the readme
The connection is established successfully, and the request launches the model to process the prompt, but the callback isn't called. However, the client connected and ready to listen from the web page receives the tokens series.
This occurs because the Dalai's request method has a typo. Currently, the event name expected is the
response
instead of theresult
string value.socket.on('response', cb)
This 'result' string value is used in the javascript script on the web page when the socket client registers a callback to listen to the tokens received via WebSocket.
socket.on('result',..
I fix this issue by changing the event name used to register the callback of the API Dalai client, for that match with the event emitted from the server side and consumed by the view.