fix: include lightweight tags in check #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Many repositories use lightweight (non-annotated) tags. This patch eliminates the scary warning that no tags were found, even if there were tags available. This makes the script match the behavior of `cog` itself (i.e., git describe --tags --abbrev=0) [[1]]. [1]: https://github.com/cocogitto/cocogitto/blob/main/src/git/revspec.rs#L347-L357 Closes: #11 Signed-off-by: Luke Hsiao <luke.hsiao@numbersstation.ai>
|
✔️ dfd5afc - Conventional commits check succeeded. |
|
@oknozor any chance we could get this merged and get a new release? |
|
Sorry for the delay I was off for a few days :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many repositories use lightweight (non-annotated) tags. This patch
eliminates the scary warning that no tags were found, even if there were
tags available.
This makes the script match the behavior of
cogitself (i.e., gitdescribe --tags --abbrev=0) [1].
Closes: #11
Signed-off-by: Luke Hsiao luke.hsiao@numbersstation.ai