Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor color type #450

Closed
Tracked by #396
cocopon opened this issue Jan 15, 2023 · 0 comments
Closed
Tracked by #396

Refactor color type #450

cocopon opened this issue Jan 15, 2023 · 0 comments
Labels
enhancement
Milestone
4.0.0

Comments

@cocopon
Copy link
Owner

cocopon commented Jan 15, 2023

I added ColorType 'int' | 'float' to Color, but it increased the number of test cases. It should be better to separate float type as a class like FloatColor and use only int type for internal color model.
@cocopon cocopon added this to the 4.0.0 milestone Jan 15, 2023
@cocopon cocopon mentioned this issue Jan 15, 2023
Closed
24 tasks
@cocopon cocopon changed the title Refactor color model Refactor color type Jan 15, 2023
cocopon added a commit that referenced this issue Jan 29, 2023
@cocopon
Refactor color types, #450
cd6140b
cocopon added a commit that referenced this issue Jan 30, 2023
@cocopon
Refactor color types, #450
f293a28
@cocopon cocopon mentioned this issue Jan 30, 2023
Merged
cocopon added a commit that referenced this issue Jan 30, 2023
@cocopon
Merge pull request #467 from cocopon/refactor-color-type
6cdff8f 
Refactor color types, #450
@cocopon cocopon closed this as completed Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.0.0
Development

No branches or pull requests
1 participant
@cocopon