Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hktmx tiled map #34

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from
Open

Conversation

skyhawk2891
Copy link

  • fixed pull request (to the right location)
  • Fixed problems with previous pull request HKTMXTiledMap #33

@psineur
Copy link
Contributor

psineur commented Nov 9, 2011

This is pretty old Pull Request, here's explanation why it's still not merged:
HKTMXTiledMap is designed to be better CCTMXTiledMap, but it doesn't support isometric nor hex orientation.
Probably we should improve it to support these orientations and try to merge it to cocos2d-iphone, instead of extensions, as a patch/improvement for CCTMXTiledMap.

So, it's not merged because:

  1. It should support all orientations to become complete.
  2. It looks more like a patch, not an extension.

This Pull Request will remain open however, because:

  1. We need a place to discuss it & improve & merge if we will decide so.
  2. Someone may find this usefull, so extensions repo will promote it a little.

@everyone, feel free to share your thoughts about this.
Thanks!

@skyhawk2891
Copy link
Author

I agree with some of the sentiments suggested here, however:

  1. Supporting iso and hex would be nice, but I'm afraid my familiarity with the 2 are completely foreign. In theory it would be as making sure the layout of the grid was okay, and then figuring out the proper clipping. The proper clipping can be difficult. It's rather easy for ortho (for obvious reasons).
  2. Not feature complete with the latest TMX specification (lacks flip)
  3. It does have some open bugs that I really should just hunker down and fix, but as they rarely are an issue in my current project,
    3a) blank layers aren't allowed (should be a simple fix)
    3b) requires POT texture (unsure if this is HKTMX or a CCTMX requirement)
    3c) http://www.cocos2d-iphone.org/forum/topic/17945/page/2#post-114731 I have no idea why the hell THAT particular one happens.
    3d) people want features like the ability to call tileAt: However, that just doesn't work in the nature of HKTMXTiledMap (things aren't ccsprites). That alone breaks the API.

* updated known issues
* Make sure we explicitly state we can use tileAt
…similar functionalities to CCTMXTiledMap. These however will penalize performance advantages of using HKTMXTiledMap

* Added true support for scaling, so that you can set your max scale, and then work with it from there. Performance degrades the more tiles you draw, per usual, but it should still be better than CCTMXTiledMap
* more support for flipped tiles
* bug fix in tileAt such that the tile respects flippedness
* Fixed non-squared textures due to stretch by texel
* Integrated Jonathan's Barnes support for rotated tiles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants