Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Improve CLI parameters DOCS-180 #92
doc: Improve CLI parameters DOCS-180 #92
Changes from all commits
756b3fb
bfca6ba
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this and I suspect that this only works for a local CLI analysis with file system access. It seems to timeout on a GitHub workflow.
Should this even be flagged as supported? Are there other options like this one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps with the client side tools integration? Haven't tested that one...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about this either. 🤔 Let's keep this thread open and we'll check again with some more time later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that I had a look at the workflow execution output, I'm thinking that perhaps it was something else that caused the GitHub Action to time out. 🤔
Could you please try running it again and see what happens?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It indeed worked this time; it was another issue altogether.
I'm still not seeing the file, although there are mentions (here and here) in the logs. I assume that it's saved in some temporary container storage and then discarded.
Should we mention this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the file is probably created correctly at the end of the Codacy Analysis CLI run. But I don't think it's necessary to further clarify this, as it isn't even very clear why anyone would want to use this option (save for maybe uploading it as an artifact of the workflow that could then be consulted later for debugging purposes.).