-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Tabs to MainPanel to show both Owned and Shared Worksheets #3422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epicfaace
reviewed
Apr 23, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
- Can we rename "Owned Worksheets" to "My Worksheets"?
- For the 100-worksheet message, instead of showing it as a tooltip, perhaps it would be best to just show it as some text at the bottom of the page, once the user scrolls down to see all the worksheets? I think it would only be relevant once the user scrolls down to the bottom.
|
epicfaace
approved these changes
Apr 27, 2021
Co-authored-by: Ashwin Ramaswami <aramaswamis@gmail.com>
Merged
adiprerepa
pushed a commit
that referenced
this pull request
May 27, 2021
* Add Tabs to MainPanel to show both "Owned Worksheets" and "Shared Worksheets" * Adjust margin for ADD button * Show the 100-worksheet message at the bottom of the page * Improve tab name * Update frontend/src/components/Dashboard/MainPanel.js Co-authored-by: Ashwin Ramaswami <aramaswamis@gmail.com> Co-authored-by: Ashwin Ramaswami <aramaswamis@gmail.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Related issues
fixes #3408
Screenshots
Checklist