Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tabs to MainPanel to show both Owned and Shared Worksheets #3422

Merged
merged 9 commits into from
Apr 27, 2021

Conversation

yuqijin
Copy link
Contributor

@yuqijin yuqijin commented Apr 22, 2021

Reasons for making this change

  • Fetch only the first 100 worksheets to avoid overload
  • Add a tooltip to remind user only the first 100 worksheets are shown
  • Add Tabs to the main panel to show both "Owned Worksheets" and "Shared Worksheets"
  • Shared Worksheets Tab is only enabled for the authorized user

Related issues

fixes #3408

Screenshots

Screen Shot 2021-04-22 at 1 00 22 PM

ezgif com-gif-maker (3)

Checklist

  • I've added a screenshot of the changes, if this is a frontend change
  • I've added and/or updated tests, if this is a backend change
  • I've run the pre-commit.sh script
  • I've updated docs, if needed

@yuqijin yuqijin requested a review from epicfaace April 22, 2021 19:58
Copy link
Member

@epicfaace epicfaace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

  • Can we rename "Owned Worksheets" to "My Worksheets"?
  • For the 100-worksheet message, instead of showing it as a tooltip, perhaps it would be best to just show it as some text at the bottom of the page, once the user scrolls down to see all the worksheets? I think it would only be relevant once the user scrolls down to the bottom.

@yuqijin
Copy link
Contributor Author

yuqijin commented Apr 23, 2021

Looks good!

  • Can we rename "Owned Worksheets" to "My Worksheets"?
  • For the 100-worksheet message, instead of showing it as a tooltip, perhaps it would be best to just show it as some text at the bottom of the page, once the user scrolls down to see all the worksheets? I think it would only be relevant once the user scrolls down to the bottom.
  • Updated according to today's meeting's discussion.
  • I think your suggestion for the 100-worksheet msg is meaningful! I have already removed the tooltip and move the message at the bottom of the page.

Screen Shot 2021-04-22 at 10 10 09 PM

My Profile:
Screen Shot 2021-04-23 at 2 40 51 PM

Other user's Profile:
Screen Shot 2021-04-23 at 2 41 05 PM

@yuqijin yuqijin requested a review from epicfaace April 24, 2021 03:35
Co-authored-by: Ashwin Ramaswami <aramaswamis@gmail.com>
@mergify mergify bot merged commit 419981e into master Apr 27, 2021
@mergify mergify bot deleted the fix/3408-new-dashboard branch April 27, 2021 20:13
@yuqijin yuqijin mentioned this pull request Apr 29, 2021
adiprerepa pushed a commit that referenced this pull request May 27, 2021
* Add Tabs to MainPanel to show both "Owned Worksheets" and "Shared Worksheets"

* Adjust margin for ADD button

* Show the 100-worksheet message at the bottom of the page

* Improve tab name

* Update frontend/src/components/Dashboard/MainPanel.js

Co-authored-by: Ashwin Ramaswami <aramaswamis@gmail.com>

Co-authored-by: Ashwin Ramaswami <aramaswamis@gmail.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New Dashboard Main Content Improvement
2 participants