Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated ugettext_lazy with gettext_lazy #108

Merged

Conversation

Ashlett
Copy link
Contributor

@Ashlett Ashlett commented Aug 26, 2021

ugettext_lazy has been an alias for gettext_lazy since Django stopped supporting Python 2 in version 2.0 (see source).

Now it is also deprecated and produces a RemovedInDjango40Warning:

RemovedInDjango40Warning: django.utils.translation.ugettext_lazy() is deprecated in favor of django.utils.translation.gettext_lazy().

See e.g. this CI run.

This PR replaces ugettext_lazy with gettext_lazy.

@Ashlett
Copy link
Contributor Author

Ashlett commented Sep 3, 2021

@codingjoe friendly ping: can you approve the workflow, and then the PR if you see fit?

@codingjoe
Copy link
Collaborator

Hi @Ashlett,

Sorry, I somehow missed the notification here. There is a rewrite of this package in the works, that supports the latest version of python-measurements, but I don't have the time to finish it. Maybe you are interested coming on as a maintainer for this project? I heard only good things about you ;)

But for now, let's merge this!

Best Johannes

@codingjoe codingjoe merged commit b5b905f into coddingtonbear:master Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants