Can declare __NFTXEligibility_init_bytes external to save gas

[code423n4]

Handle

shw

Vulnerability details

Impact

The function __NFTXEligibility_init_bytes in the contract NFTXEligibility can be declared external to save gas. Contracts that inherit NFTXEligibility and override __NFTXEligibility_init_bytes, i.e., the NFTX*Eligibility ones, can also be declared external. Please refer to the following links as details.

Proof of Concept

Referenced code:
NFTXEligibility.sol#L13
NFTXDeferEligibility.sol#L32-L37
NFTXListEligibility.sol#L28-L33
NFTXMintRequestEligibility.sol#L58-L68
NFTXRangeEligibility.sol#L44-L54
(NFTXUniqueEligibility.sol#L47-L57)[https://github.com/code-423n4/2021-05-nftx/blob/main/nftx-protocol-v2/contracts/solidity/eligibility/NFTXUniqueEligibility.sol#L47-L57]

Please refer to the files 500.js, 500-original.png, and 500-changed.png in the following link.
PoC: Link to PoC

Tools Used

None

Recommended Mitigation Steps

Change public to external and bytes memory to bytes calldata.

[cemozerr]

Duplicate of #64