no check _rangeStart<=_rangeEnd

[code423n4]

Handle

gpersoon

Vulnerability details

Impact

In NFTXRangeEligibility.sol a range is defined via __NFTXEligibility_init and setEligibilityPreferences.
No check is done to make sure _rangeStart<=_rangeEnd, so one could accidentally define as range that is effectively empty.

Proof of Concept

function setEligibilityPreferences(uint256 _rangeStart, uint256 _rangeEnd) externalvirtual onlyOwner {
rangeStart = _rangeStart;
rangeEnd = _rangeEnd;
emit RangeSet(_rangeStart, _rangeEnd);
}

Tools Used

Editor

Recommended Mitigation Steps

Consider adding a check to make sure _rangeStart<=_rangeEnd