Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unbounded iteration in NFTXEligiblityManager.distribute over _feeReceivers #47

Open
code423n4 opened this issue May 11, 2021 · 0 comments
Open

Unbounded iteration in NFTXEligiblityManager.distribute over _feeReceivers #47

code423n4 opened this issue May 11, 2021 · 0 comments
Labels
2 (Med Risk) Acknowledged bug Something isn't working

Comments

@code423n4
Copy link
Contributor

Handle

@cmichelio

Vulnerability details

Vulnerability Details

NFTXEligiblityManager.distribute iterates over all _feeReceivers.

Impact

If the number of _feeReceivers gets too big, the transaction's gas cost could exceed the block gas limit and make it impossible to call distribute at all.

Recommended Mitigation Steps

Keep the number of _feeReceivers small.
@code423n4 code423n4 added 2 (Med Risk) bug Something isn't working labels May 11, 2021
code423n4 added a commit that referenced this issue May 11, 2021
@code423n4
@cmichelio issue #47
551b7c4
@0xKiwi 0xKiwi closed this as completed May 22, 2021
@cemozerr cemozerr reopened this May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
2 (Med Risk) Acknowledged bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@0xKiwi @cemozerr @code423n4