Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lack of non-zero address check in setWithdrawHandler #118

Closed
code423n4 opened this issue Jul 10, 2021 · 2 comments
Closed

Lack of non-zero address check in setWithdrawHandler #118

code423n4 opened this issue Jul 10, 2021 · 2 comments
Labels
1 (Low Risk) bug Something isn't working duplicate This issue or pull request already exists

Comments

@code423n4
Copy link
Contributor

Handle

shw

Vulnerability details

Impact

The setWithdrawHandler function of Controller does not check that the provided parameter _emergencyHandler is non-zero. However, a similar parameter _withdrawHandler is checked.

Proof of Concept

Referenced code:
Controller.sol#L105-L110

Recommended Mitigation Steps

Add require(_emergencyHandler != address(0), "setWithdrawHandler: 0x"); after line 106.
@code423n4 code423n4 added 1 (Low Risk) bug Something isn't working labels Jul 10, 2021
code423n4 added a commit that referenced this issue Jul 10, 2021
@code423n4
shw issue #118
2bd4651
@kitty-the-kat kitty-the-kat added the duplicate This issue or pull request already exists label Jul 14, 2021
@kitty-the-kat
Copy link
Collaborator

#5

@ghoul-sol ghoul-sol reopened this Jul 25, 2021
@ghoul-sol
Copy link
Collaborator

Duplicate of #5

@ghoul-sol ghoul-sol marked this as a duplicate of #5 Jul 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 (Low Risk) bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kitty-the-kat @ghoul-sol @code423n4