Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused code #71

Open
code423n4 opened this issue Jul 7, 2021 · 1 comment
Open

Unused code #71

code423n4 opened this issue Jul 7, 2021 · 1 comment
Labels

Comments

@code423n4
Copy link
Contributor

Handle

pauliax

Vulnerability details

Impact

contract LifeGuard3Pool has unused events: LogHealhCheckUpdate, LogNewEmergencyWithdrawal. Interfaces IHarvest and IStake are not used. contract Buoy3Pool has unused variable TIME_LIMIT and a variable that is only initialized but never used: lpToken.
Style issue: BASIS_POINTS all caps indicate it should be a constant, however, an owner can change it by calling function setBasisPointsLmit.

Recommended Mitigation Steps

Make use of this code or remove it.

@code423n4 code423n4 added 0 (Non-critical) bug Something isn't working labels Jul 7, 2021
code423n4 added a commit that referenced this issue Jul 7, 2021
@kitty-the-kat kitty-the-kat added duplicate This issue or pull request already exists sponsor confirmed and removed duplicate This issue or pull request already exists labels Jul 14, 2021
@ghoul-sol
Copy link
Collaborator

BASIS_POINTS is a duplicate of #23. It's just part of the described issue so I won't make it a duplicate but in the future it would be better to split "unused code" and "style convention" issues. Otherwise, I have to make a subjective judgement to degrade the issue to a duplicate or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants