Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two SafeApprove calls when it could be just one #84

Open
code423n4 opened this issue Jul 7, 2021 · 1 comment
Open

Two SafeApprove calls when it could be just one #84

code423n4 opened this issue Jul 7, 2021 · 1 comment

Comments

@code423n4
Copy link
Contributor

Handle

a_delamo

Vulnerability details

Impact

In LifeGuard3Pool and BaseVaultAdaptor contracts, we are doing two approve calls when we could just use one. Doing two safeApprove calls with value = 0 and after value = max doesn't seem to provide any extra feature.

For example:

        IERC20(_token).safeApprove(address(_vault), 0);
        IERC20(_token).safeApprove(address(_vault), type(uint256).max);
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Jul 7, 2021
code423n4 added a commit that referenced this issue Jul 7, 2021
@kitty-the-kat
Copy link
Collaborator

causes issues with usdt otherwise - could create separate logic to just deal with usdt, but is non-critical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants