Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

event LogTransfer is only emitted in function transfer #88

Open
code423n4 opened this issue Jul 7, 2021 · 0 comments
Open

event LogTransfer is only emitted in function transfer #88

code423n4 opened this issue Jul 7, 2021 · 0 comments

Comments

@code423n4
Copy link
Contributor

Handle

pauliax

Vulnerability details

Impact

Not sure what are the intentions with this event but I expect to see it not only in function transfer but also in other functions that update user balances.

Recommended Mitigation Steps

transferFrom should LogTransfer(sender, recipient, amount);
mint should LogTransfer(address(0), account, amount);
burn should LogTransfer(account, address(0), amount);
burnAll should LogTransfer(account, address(0), burnAmount);

@code423n4 code423n4 added 0 (Non-critical) bug Something isn't working labels Jul 7, 2021
code423n4 added a commit that referenced this issue Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants