Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Order of parameters in KickReward event #20

Open
code423n4 opened this issue Sep 8, 2021 · 1 comment
Open

Order of parameters in KickReward event #20

code423n4 opened this issue Sep 8, 2021 · 1 comment

Comments

@code423n4
Copy link
Contributor

Handle

pauliax

Vulnerability details

Impact

event KickReward in CvxLocker declares the first parameter as _user and second as _kicked, however, seems that these parameters are actually emitted in the opposite order:
emit KickReward(_rewardAddress, _account, reward);

Recommended Mitigation Steps

I think it should be this:
emit KickReward(_account, _rewardAddress, reward);

@code423n4 code423n4 added 0 (Non-critical) bug Something isn't working labels Sep 8, 2021
code423n4 added a commit that referenced this issue Sep 8, 2021
@C2tP-C2tP
Copy link
Collaborator

Ah yeah i can see how that could be taken either way. should have done _kicker and _kickee maybe to be more clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants