Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

events in BaseStrategy are never emitted #21

Open
code423n4 opened this issue Sep 8, 2021 · 1 comment
Open

events in BaseStrategy are never emitted #21

code423n4 opened this issue Sep 8, 2021 · 1 comment
Labels
0 (Non-critical) bug Something isn't working

Comments

@code423n4
Copy link
Contributor

Handle

pauliax

Vulnerability details

Impact

events in BaseStrategy are declared but never used, e.g. I expected to see SetPerformanceFeeStrategist emitted in function setPerformanceFeeStrategist.

Recommended Mitigation Steps

Emit declared events in BaseStrategy.
@code423n4 code423n4 added 0 (Non-critical) bug Something isn't working labels Sep 8, 2021
code423n4 added a commit that referenced this issue Sep 8, 2021
@code423n4
pauliax issue #21
d66825f
@GalloDaSballo
Copy link
Collaborator

Would prefer list of events

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 (Non-critical) bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@GalloDaSballo @code423n4