Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Race condition on ERC20 approval #120

Open
code423n4 opened this issue Sep 30, 2021 · 0 comments
Open

Race condition on ERC20 approval #120

code423n4 opened this issue Sep 30, 2021 · 0 comments
Labels
1 (Low Risk) bug Something isn't working sponsor-confirmed

Comments

@code423n4
Copy link
Contributor

Handle

tensors

Vulnerability details

Using approve() to manage allowances opens yourself and users of the token up to frontrunning.
Best practice, but doesn't usually matter.

https://github.com/code-423n4/2021-09-wildcredit/blob/c48235289a25b2134bb16530185483e8c85507f8/contracts/LPTokenMaster.sol#L87

See also:
0xProject/0x-monorepo#850

I recommend using increase/decreaseAllowance instead.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 (Low Risk) bug Something isn't working sponsor-confirmed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@talegift @code423n4