Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

public functions in Factory can be external #14

Open
code423n4 opened this issue Oct 9, 2021 · 1 comment
Open

public functions in Factory can be external #14

code423n4 opened this issue Oct 9, 2021 · 1 comment
Labels
bug Warden finding G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

pants

Vulnerability details

The public functions Factory.setMinLicenseFee(), Factory.setAuctionDecrement(), Factory.setAuctionMultiplier(), Factory.setBondPercentDiv(), Factory.setOwnerSplit() and Factory.proposeBasketLicense() are never called by Factory. Therefore, their visibility can be reduced to external.

Impact

external functions are cheaper than public functions.

Proof of Concept

https://gus-tavo-guim.medium.com/public-vs-external-functions-in-solidity-b46bcf0ba3ac

Tool Used

Manual code review.

Recommended Mitigation Steps

Define these functions as public.
code423n4 added a commit that referenced this issue Oct 9, 2021
@code423n4
pants issue #14
520da7f
@frank-beard frank-beard added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Nov 6, 2021
@GalloDaSballo
Copy link
Collaborator

Finding is valid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Warden finding G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@GalloDaSballo @code423n4 @frank-beard