Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary SLOADs in Factory #35

Open
code423n4 opened this issue Oct 9, 2021 · 1 comment
Open

Unnecessary SLOADs in Factory #35

code423n4 opened this issue Oct 9, 2021 · 1 comment
Labels
bug Warden finding G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

pants

Vulnerability details

The functions Factory.getProposalWeights() and Factory.createBasket() read values from storage multiple times instead of caching them in local variables:

  • Factory.getProposalWeights() reads _proposals[id] twice.
  • Factory.createBasket() reads _proposals[idNumber] twice.

Impact

Storage reads are much more expensive than reading local variables.

Tool Used

Manual code review.

Recommended Mitigation Steps

Read these values from storage once, cache them in local variables and then read them again from the local variables.
code423n4 added a commit that referenced this issue Oct 9, 2021
@code423n4
pants issue #35
69718d0
@frank-beard frank-beard added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Nov 6, 2021
@GalloDaSballo
Copy link
Collaborator

Agree with finding

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Warden finding G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@GalloDaSballo @code423n4 @frank-beard