Empty else if block in Basket.publishNewIndex()

[code423n4]

Handle

pants

Vulnerability details

The function Basket.publishNewIndex() contains the following code:

if (auction.auctionOngoing() == false) {
	// ...
} else if (auction.hasBonded()) {

} else {
	// ...
}

Impact

Empty code blocks increase gas costs (add overheads) and make the code less readable.

Tool Used

Manual code review.

Recommended Mitigation Steps

Get rid of the empty block by changing this code to:

if (auction.auctionOngoing() == false) {
	// ...
} else if (!auction.hasBonded()) {
	// ...
}

[GalloDaSballo]

Agree with the finding and improvement looks good