Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Events in IAuction don't use the indexed keyword #44

Open
code423n4 opened this issue Oct 9, 2021 · 1 comment
Open

Events in IAuction don't use the indexed keyword #44

code423n4 opened this issue Oct 9, 2021 · 1 comment
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Warden finding sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons

Comments

@code423n4
Copy link
Contributor

Handle

pants

Vulnerability details

The events defined in IAuction don't use the indexed keyword for any of their values.

Impact

Users can't easily keep track of logged events, resulting with a poor user experience.

Tool Used

Manual code review.

Recommended Mitigation Steps

Use the indexed keyword whenever necessary for these events.
@code423n4 code423n4 added 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Warden finding labels Oct 9, 2021
code423n4 added a commit that referenced this issue Oct 9, 2021
@code423n4
pants issue #44
76a20b5
@frank-beard frank-beard added the sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons label Nov 6, 2021
@GalloDaSballo
Copy link
Collaborator

Personal opinion here as I believe you can still filter unindexed parameters, and using theGraph makes this a non-issue, that said, the sponsor acknowledges so let's mark as valid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Warden finding sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@GalloDaSballo @code423n4 @frank-beard