Comparisons to boolean constant

[code423n4]

Handle

loop

Vulnerability details

In a couple of instances a boolean (return) value is compared to false. Consider using the ! operator instead.

Impact

Unnecessary comparison to a boolean constant, only using the boolean value is slightly cheaper on gas.

Proof of Concept

Boolean constant comparisons:

• https://github.com/code-423n4/2021-10-defiprotocol/blob/main/contracts/contracts/Auction.sol#L36
• https://github.com/code-423n4/2021-10-defiprotocol/blob/main/contracts/contracts/Basket.sol#L88
• https://github.com/code-423n4/2021-10-defiprotocol/blob/main/contracts/contracts/Basket.sol#L101
• https://github.com/code-423n4/2021-10-defiprotocol/blob/main/contracts/contracts/Basket.sol#L191
• https://github.com/code-423n4/2021-10-defiprotocol/blob/main/contracts/contracts/Basket.sol#L227

Tools Used

Slither & Remix

[GalloDaSballo]

I don't believe this to be correct, the boolean in the check may increase the cost of deployment (you could save by adding it as a constant FALSE = false)
But the comparison and the not operator have the same cost

I guess removing it would save deployment gas cost