New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unchecked modifiers should be used when over/under-flow isnt an issue to save gas #71

Open

code423n4 opened this issue Oct 10, 2021 · 1 comment

Labels

bug G (Gas Optimization) sponsor acknowledged

Contributor

code423n4 commented Oct 10, 2021

Handle

tensors

Vulnerability details

They could be used in some places for small gas savings:

https://github.com/code-423n4/2021-10-defiprotocol/blob/7ca848f2779e2e64ed0b4756c02f0137ecd73e50/contracts/contracts/Basket.sol#L251

https://github.com/code-423n4/2021-10-defiprotocol/blob/7ca848f2779e2e64ed0b4756c02f0137ecd73e50/contracts/contracts/Basket.sol#L130

https://github.com/code-423n4/2021-10-defiprotocol/blob/7ca848f2779e2e64ed0b4756c02f0137ecd73e50/contracts/contracts/Basket.sol#L117

code423n4 added bug G (Gas Optimization) labels

code423n4 added a commit that referenced this issue


          tensors issue #71

f58a472

frank-beard added the sponsor acknowledged label

Collaborator

GalloDaSballo commented Dec 19, 2021

Agree that unchecked would save gas and the instances the warden mentions are valid

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment