Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typos #113

Closed
code423n4 opened this issue Oct 27, 2021 · 1 comment
Closed

Typos #113

code423n4 opened this issue Oct 27, 2021 · 1 comment
Assignees
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working disagree with severity Sponsor confirms validity, but disagrees with warden’s risk assessment (sponsor explain in comments)

Comments

@code423n4
Copy link
Contributor

Handle

WatchPug

Vulnerability details

https://github.com/code-423n4/2021-10-mochi/blob/8458209a52565875d8b2cefcb611c477cefb9253/projects/mochi-core/contracts/interfaces/IMochiVault.sol#L14-L20

enum Status {
    Invalid, // not minted
    Idle, // debt = 0, collateral = 0
    Collaterized, // debt = 0, collateral > 0
    Active, // debt > 0, collateral > 0
    Liquidated
}

Collaterized should be Collateralized.

https://github.com/code-423n4/2021-10-mochi/blob/8458209a52565875d8b2cefcb611c477cefb9253/projects/mochi-core/contracts/interfaces/IMochiVault.sol#L25-L34

function details(uint256 _nftId)
    external
    view
    returns (
        Status,
        uint256 collateral,
        uint256 debt,
        uint256 debtIndexe,
        address refferer
    );

debtIndexe should be debtIndex.
refferer should be referrer.

@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working labels Oct 27, 2021
code423n4 added a commit that referenced this issue Oct 27, 2021
@r2moon r2moon added the disagree with severity Sponsor confirms validity, but disagrees with warden’s risk assessment (sponsor explain in comments) label Oct 29, 2021
@r2moon
Copy link
Collaborator

r2moon commented Oct 29, 2021

this is not risk

@ghoul-sol ghoul-sol added 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation and removed 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments labels Nov 2, 2021
@0xleastwood 0xleastwood self-assigned this Nov 3, 2021
@leekt leekt closed this as completed Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working disagree with severity Sponsor confirms validity, but disagrees with warden’s risk assessment (sponsor explain in comments)
Projects
None yet
Development

No branches or pull requests

5 participants