Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsafe int256 casts in accrueDebt #128

Closed
code423n4 opened this issue Oct 27, 2021 · 0 comments
Closed

Unsafe int256 casts in accrueDebt #128

code423n4 opened this issue Oct 27, 2021 · 0 comments
Assignees
@0xleastwood
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

cmichel

Vulnerability details

As MochiVault.accrueDebt function performs unsafe casts: claimable += int256(increased);.

If the unsigned values are above the maximum signed value (type(int256).max), it will be interpreted as a negative value instead.

Impact

Even though overflowing the max int256 value is unlikely, it's still recommended to use safe casts.

Recommended Mitigation Steps

Make sure the value fits into the type first by using a SafeCast library.
@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working labels Oct 27, 2021
code423n4 added a commit that referenced this issue Oct 27, 2021
@code423n4
cmichel issue #128
eaf3bf4
@r2moon r2moon added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Oct 29, 2021
@0xleastwood 0xleastwood self-assigned this Nov 2, 2021
@leekt leekt closed this as completed Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xleastwood 0xleastwood

Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@leekt @r2moon @0xleastwood @code423n4