Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing low-level call success check #132

Closed
code423n4 opened this issue Oct 27, 2021 · 1 comment
Closed

Missing low-level call success check #132

code423n4 opened this issue Oct 27, 2021 · 1 comment
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working duplicate This issue or pull request already exists

Comments

@code423n4
Copy link
Contributor

Handle

cmichel

Vulnerability details

The MochiVaultProxy.updateTemplate performs a low-level call to beacon and does not check the success return value.

Impact

If the beacon is set to the wrong address and the call fails, it will not be noticeable.

Recommended Mitigation Steps

Check for success for the address(beacon).call(abi.encode(_newTemplate)) call.
@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working labels Oct 27, 2021
code423n4 added a commit that referenced this issue Oct 27, 2021
@code423n4
cmichel issue #132
b9c30bf
@r2moon r2moon added the invalid This doesn't seem right label Oct 29, 2021
@r2moon
Copy link
Collaborator

r2moon commented Oct 29, 2021

duplicated with #76

@ghoul-sol ghoul-sol added duplicate This issue or pull request already exists and removed invalid This doesn't seem right labels Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@r2moon @ghoul-sol @code423n4