Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate check of supported token on flash loan #160

Closed
code423n4 opened this issue Oct 27, 2021 · 0 comments
Closed

Duplicate check of supported token on flash loan #160

code423n4 opened this issue Oct 27, 2021 · 0 comments
Assignees
Labels
bug Something isn't working G (Gas Optimization) sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons

Comments

@code423n4
Copy link
Contributor

Handle

pauliax

Vulnerability details

Impact

function flashLoan does not necesseraly need this check:
require(_token == address(this), "!supported");
as it will be later checked again in function flashFee.

Recommended Mitigation Steps

Consider removing it to reduce gas usage.

@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Oct 27, 2021
code423n4 added a commit that referenced this issue Oct 27, 2021
@r2moon r2moon added the sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons label Oct 29, 2021
@0xleastwood 0xleastwood self-assigned this Nov 3, 2021
@leekt leekt closed this as completed Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working G (Gas Optimization) sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
Projects
None yet
Development

No branches or pull requests

4 participants