Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gas optimization: Placement of require statements in MochiVault.sol #27

Open
code423n4 opened this issue Oct 23, 2021 · 0 comments
Open

Gas optimization: Placement of require statements in MochiVault.sol #27

code423n4 opened this issue Oct 23, 2021 · 0 comments
Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

gzeon

Vulnerability details

Impact

Some of the require statements in MochiVault.sol can be placed earlier to reduce gas usage on revert

Proof of Concept

https://github.com/code-423n4/2021-10-mochi/blob/main/projects/mochi-core/contracts/vault/MochiVault.sol
L226-227: can be placed at the very top of the function to avoid the expensive cssr call
L237: can be placed before initialization of increasingDebt

Tools Used

None

Recommended Mitigation Steps

Relocate the said require statements
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Oct 23, 2021
code423n4 added a commit that referenced this issue Oct 23, 2021
@code423n4
gzeon issue #27
f7e4d33
@r2moon r2moon added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Oct 27, 2021
@r2moon r2moon mentioned this issue Oct 27, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@r2moon @code423n4