Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lack of input validation of arrays #31

Open
code423n4 opened this issue Oct 23, 2021 · 1 comment
Open

Lack of input validation of arrays #31

code423n4 opened this issue Oct 23, 2021 · 1 comment
Assignees
@0xleastwood
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons

Comments

@code423n4
Copy link
Contributor

Handle

gzeon

Vulnerability details

Impact

Some input validation of variable arrays are missing

Proof of Concept

https://github.com/code-423n4/2021-10-mochi/blob/main/projects/mochi-core/contracts/profile/MochiProfileV0.sol
L64,82,91: if length of the input arrays are not equal, the call will revert

Tools Used

None

Recommended Mitigation Steps

Add proper input validation
@code423n4 code423n4 added 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working labels Oct 23, 2021
code423n4 added a commit that referenced this issue Oct 23, 2021
@code423n4
gzeon issue #31
3ed2939
@r2moon r2moon added the sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons label Oct 27, 2021
@r2moon
Copy link
Collaborator

r2moon commented Oct 27, 2021

It is correct, but since those functions can be called by only governance, we don't need to fix it.

@r2moon r2moon mentioned this issue Oct 29, 2021
Closed
@0xleastwood 0xleastwood self-assigned this Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xleastwood 0xleastwood

Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working sponsor acknowledged Technically the issue is correct, but we're not going to resolve it for XYZ reasons
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@r2moon @0xleastwood @code423n4