Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused storage variable in UsdmMinter.sol #42

Closed
code423n4 opened this issue Oct 25, 2021 · 0 comments
Closed

Unused storage variable in UsdmMinter.sol #42

code423n4 opened this issue Oct 25, 2021 · 0 comments
Assignees
Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

harleythedog

Vulnerability details

Impact

In UsdmMinter.sol, there is a public array called "factories", but this array is never added to or altered anywhere within the contract. So, this array will always be empty and doesn't seem like it would be of any use to anyone, so I recommend removing it to save gas.

Proof of Concept

Variable declaration here: https://github.com/code-423n4/2021-10-mochi/blob/main/projects/mochi-core/contracts/minter/UsdmMinter.sol#:~:text=address%5B%5D%20public%20factories%3B

Tools Used

Manual inspection.

Recommended Mitigation Steps

Remove unused variable to optimize gas.

@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Oct 25, 2021
code423n4 added a commit that referenced this issue Oct 25, 2021
@r2moon r2moon added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Oct 29, 2021
@0xleastwood 0xleastwood self-assigned this Nov 2, 2021
@leekt leekt closed this as completed Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Development

No branches or pull requests

4 participants