Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing zero-address checks #86

Closed
code423n4 opened this issue Oct 27, 2021 · 1 comment
Closed

Missing zero-address checks #86

code423n4 opened this issue Oct 27, 2021 · 1 comment
Assignees
@0xleastwood
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

loop

Vulnerability details

Some contracts are missing a zero-check for addresses where an address is given as a parameter which should never be zero. Zero-address checks are a best-practise for input validation of critical address parameters as accidental input of a zero address might result in exceptions, burn fees/tokens or force redeployment of contracts.

Proof of Concept

Recommended Mitigation Steps

Add a zero address check
@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working labels Oct 27, 2021
code423n4 added a commit that referenced this issue Oct 27, 2021
@code423n4
loop issue #86
4937750
@r2moon r2moon added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Oct 27, 2021
@r2moon r2moon mentioned this issue Oct 27, 2021
Closed
@0xleastwood 0xleastwood self-assigned this Nov 2, 2021
@ghoul-sol ghoul-sol added 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation and removed 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments labels Nov 2, 2021
@ghoul-sol
Copy link
Collaborator

best practices, non-critical

@leekt leekt closed this as completed Nov 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xleastwood 0xleastwood

Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@leekt @r2moon @0xleastwood @ghoul-sol @code423n4