Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unnecessary usage of SafeMath in vesting contracts #107

Closed
code423n4 opened this issue Nov 7, 2021 · 1 comment
Closed

Unnecessary usage of SafeMath in vesting contracts #107

code423n4 opened this issue Nov 7, 2021 · 1 comment
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization)

Comments

@code423n4
Copy link
Contributor

Handle

Ruhum

Vulnerability details

Impact

Solidity ^0.8.0 has built-in over- & underflow checks. You don't have to use OpenZeppelin's SafeMath library.

Proof of Concept

https://github.com/code-423n4/2021-11-bootfinance/blob/main/vesting/contracts/AirdropDistribution.sol#L20

https://github.com/code-423n4/2021-11-bootfinance/blob/main/vesting/contracts/AirdropDistribution.sol#L581-L582

https://github.com/code-423n4/2021-11-bootfinance/blob/main/vesting/contracts/InvestorDistribution.sol#L19

https://github.com/code-423n4/2021-11-bootfinance/blob/main/vesting/contracts/InvestorDistribution.sol#L171-L172

https://github.com/code-423n4/2021-11-bootfinance/blob/main/vesting/contracts/Vesting.sol#L20

Multiple calls to add() and sub() in Vesting.sol

Tools Used

Manual Analysis

Recommended Mitigation Steps

Replace with basic solidity operations, e.g. + and -, etc.
@code423n4 code423n4 added 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working labels Nov 7, 2021
code423n4 added a commit that referenced this issue Nov 7, 2021
@code423n4
Ruhum issue #107
33787d4
@chickenpie347 chickenpie347 added the duplicate This issue or pull request already exists label Jan 3, 2022
@chickenpie347
Copy link
Collaborator

Duplicate of #7 , #29

@0xean 0xean added G (Gas Optimization) and removed 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation labels Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chickenpie347 @0xean @code423n4