Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use of SafeMath with pragma ^0.8.0 #113

Closed
code423n4 opened this issue Nov 7, 2021 · 1 comment
Closed

Use of SafeMath with pragma ^0.8.0 #113

code423n4 opened this issue Nov 7, 2021 · 1 comment
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization)

Comments

@code423n4
Copy link
Contributor

Handle

Reigada

Vulnerability details

Impact

Contracts: AirdropDistribution.sol, InvestorDistribution.sol, Vesting.sol and PublicSale.sol are using SafeMath with a pragma ^0.8.0. This makes no sense and just causes more gas to be used as versions ^0.8.0 of Solidity already check for overflows/underflows.

https://github.com/ethereum/solidity/releases/tag/v0.8.0

Tools Used

Manual testing

Recommended Mitigation Steps

Remove SafeMath and modify the mathematical operations to use the standard math operators.
@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Nov 7, 2021
code423n4 added a commit that referenced this issue Nov 7, 2021
@code423n4
Reigada issue #113
4ee9d85
@chickenpie347 chickenpie347 added the duplicate This issue or pull request already exists label Jan 3, 2022
@chickenpie347
Copy link
Collaborator

Duplicate of #7

@chickenpie347 chickenpie347 marked this as a duplicate of #7 Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chickenpie347 @code423n4