Assignment Of Variables To Default (PublicSale.sol) #119
Labels
bug
Something isn't working
duplicate
This issue or pull request already exists
G (Gas Optimization)
sponsor confirmed
Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Handle
ye0lde
Vulnerability details
Impact
Assignment Of Variables To Default (PublicSale.sol)
Note I already submitted a similar ticket for swap.sol. I wanted to just add this to that ticket.
Variables are being assigned their default value which is unnecessary.
Removing the assignment will save gas when deploying.
Proof of Concept
https://github.com/code-423n4/2021-11-bootfinance/blob/7c457b2b5ba6b2c887dafdf7428fd577e405d652/tge/contracts/PublicSale.sol#L125-L126
Tools Used
Visual Studio Code, Remix
Recommended Mitigation Steps
Remove the assignments.
Or if you feel it is important to show the default assignment will occur then replace the assignments with a comment.
The text was updated successfully, but these errors were encountered: