Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assignment Of Variables To Default (PublicSale.sol) #119

Closed
code423n4 opened this issue Nov 7, 2021 · 1 comment
Closed

Assignment Of Variables To Default (PublicSale.sol) #119

code423n4 opened this issue Nov 7, 2021 · 1 comment
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

ye0lde

Vulnerability details

Impact

Assignment Of Variables To Default (PublicSale.sol)

Note I already submitted a similar ticket for swap.sol. I wanted to just add this to that ticket.

Variables are being assigned their default value which is unnecessary.
Removing the assignment will save gas when deploying.

Proof of Concept

https://github.com/code-423n4/2021-11-bootfinance/blob/7c457b2b5ba6b2c887dafdf7428fd577e405d652/tge/contracts/PublicSale.sol#L125-L126

Tools Used

Visual Studio Code, Remix

Recommended Mitigation Steps

Remove the assignments.

Or if you feel it is important to show the default assignment will occur then replace the assignments with a comment.

@code423n4 code423n4 added bug Something isn't working G (Gas Optimization) labels Nov 7, 2021
code423n4 added a commit that referenced this issue Nov 7, 2021
@chickenpie347 chickenpie347 added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Jan 3, 2022
@0xean
Copy link
Collaborator

0xean commented Jan 8, 2022

duplicate of #5

@0xean 0xean closed this as completed Jan 8, 2022
@0xean 0xean added the duplicate This issue or pull request already exists label Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists G (Gas Optimization) sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Development

No branches or pull requests

3 participants