Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Commented code left in codebase #151

Closed
code423n4 opened this issue Nov 9, 2021 · 1 comment
Closed

Commented code left in codebase #151

code423n4 opened this issue Nov 9, 2021 · 1 comment
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working duplicate This issue or pull request already exists

Comments

@code423n4
Copy link
Contributor

Handle

loop

Vulnerability details

There are some lines of commented out code in the following files:

  • Swap.sol
  • SwapUtils.sol
  • Vesting.sol

Proof of Concept

Following lines contain commented code or comments describing the commented code.

Recommended Mitigation Steps

Remove (commented) code which is no longer used.
@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working labels Nov 9, 2021
code423n4 added a commit that referenced this issue Nov 9, 2021
@code423n4
loop issue #151
8bfe7d9
@chickenpie347 chickenpie347 added the duplicate This issue or pull request already exists label Jan 3, 2022
@chickenpie347
Copy link
Collaborator

Duplicate of #140

@chickenpie347 chickenpie347 marked this as a duplicate of #140 Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chickenpie347 @code423n4