Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not possible to set maximum fee in Swap.sol #156

Closed
code423n4 opened this issue Nov 9, 2021 · 1 comment
Closed

Not possible to set maximum fee in Swap.sol #156

code423n4 opened this issue Nov 9, 2021 · 1 comment
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working duplicate This issue or pull request already exists sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")

Comments

@code423n4
Copy link
Contributor

Handle

loop

Vulnerability details

When setting the fees, the parameters _fee, _adminFee and _withdrawFee are used. These parameters can however not be set to the maximum fee value due to require statements having a requirement of them being less than the max fee.

Proof of Concept

https://github.com/code-423n4/2021-11-bootfinance/blob/main/customswap/contracts/Swap.sol#L192-L200

Recommended Mitigation Steps

Change < to <= to include the maximum fee as well.
@code423n4 code423n4 added 1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working labels Nov 9, 2021
code423n4 added a commit that referenced this issue Nov 9, 2021
@code423n4
loop issue #156
aee63f7
@chickenpie347 chickenpie347 added the sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity") label Jan 3, 2022
@0xean
Copy link
Collaborator

0xean commented Jan 8, 2022

duplicate of #254

@0xean 0xean closed this as completed Jan 8, 2022
@0xean 0xean added the duplicate This issue or pull request already exists label Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1 (Low Risk) Assets are not at risk. State handling, function incorrect as to spec, issues with comments bug Something isn't working duplicate This issue or pull request already exists sponsor confirmed Sponsor agrees this is a problem and intends to fix it (OK to use w/ "disagree with severity")
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@chickenpie347 @0xean @code423n4