Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unlocked pragma #158

Closed
code423n4 opened this issue Nov 9, 2021 · 1 comment
Closed

Unlocked pragma #158

code423n4 opened this issue Nov 9, 2021 · 1 comment
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working duplicate This issue or pull request already exists

Comments

@code423n4
Copy link
Contributor

Handle

loop

Vulnerability details

Pragma version for contracts in /vesting is ^0.8.4, pragma version for contract in /tge is ^0.8.0. Keep the pragma compiler version locked to a specific version as a best practice. Preferably the one everything has been tested most with. Considering the different contracts also have a different minimal pragma version it's also a good idea to double check the compiler used when deploying the contracts.

See also:
https://consensys.github.io/smart-contract-best-practices/recommendations/#lock-pragmas-to-specific-compiler-version
@code423n4 code423n4 added 0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working labels Nov 9, 2021
code423n4 added a commit that referenced this issue Nov 9, 2021
@code423n4
loop issue #158
fd3dc3b
@chickenpie347 chickenpie347 added the duplicate This issue or pull request already exists label Jan 3, 2022
@chickenpie347
Copy link
Collaborator

Duplicate of #29

@chickenpie347 chickenpie347 marked this as a duplicate of #29 Jan 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
0 (Non-critical) Code style, clarity, syntax, versioning, off-chain monitoring (events etc), exclude gas optimisation bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@chickenpie347 @code423n4